Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix autocompletes #3806

Merged
merged 3 commits into from
Oct 31, 2024
Merged

fix autocompletes #3806

merged 3 commits into from
Oct 31, 2024

Conversation

LEstradioto
Copy link
Contributor

Changes

  • sometimes autocomplete="off" wont work so added autocomplete="new-password" in cases where made sense
  • wrap form and added username as hidden to try a better autofill
  • uuid because modals are rendered multiple times in same page, to avoid id dups (future improvement would be a single re-usable modal component)

Issues

Following #3640 then:

@peaklabs-dev
Copy link
Member

Thank you for the PR 💜.

@peaklabs-dev peaklabs-dev merged commit 901af17 into coollabsio:next Oct 31, 2024
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LEstradioto @peaklabs-dev @andrasbacsai